Always allow changing player notification preferences on Android 13+ #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ettings on Android 13 and above.
AudricV
added
device/software specific
|
|
I tried it out, disabled notification permission and switched the thumbnail setting, seems to work fine. |
Stypox
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Code looks good to me. I tested the following after disabling notifications (either by denying the permission or by manually disabling notifications in the app preferences on lower android versions).
- on my phone (Android 13) -> player notifications visible and option visible
- on API 34 emulated -> player notifications visible and option visible
- on API 31 emulated -> player notification hidden and option hidden
- on API 22 emulated -> player notification hidden and option hidden
Everything seems to work fine. Thank you for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Since Android 13 media player notifications are exempt from the notification settings/permission, however NewPipe currently disables all preferences in the notification section preventing the user from entering the player notification page.
I have tested this on my device and neither the global notification toggle/permission, nor disabling the specific channel used for player notifications would hide it.
Since system settings don't affect the display of the player notification, this PR makes it so that only the new stream notification preferences are disabled, when notifications are blocked by the system.
Before/After Screenshots/Screen Record
(Both screenshots taken on Android 15 with notification permission denied)
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence